18044 enable alert for plugins in script #18100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Dec 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #18044
script.html already derives from generic/object.html which has the plugin alert include, the issue was that the alert is keyed off of the context var
objectand the view usesscript. It isn't really DRY to pass in both object and script, but to change would require it to change in the template extras/script/base.html which is included in other templates and this would cause the the branching message to also appear in those templates which isn't desired. We could then mask that out in the template include, but this way just keeps it isolated.Note: This will not display anything without changes in the branching plugin which will be in a separate PR for that project. Screenshot shown with change in branching plugin to enable an alert here.