Skip to content

Fixes: #17820 - Store default values from custom fields on newly created module components #18084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Fixes: #17820 - Store default values from custom fields on newly created module components #18084

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca13500
Store default values from custom fields on newly created module compo…
bctiemann Nov 25, 2024
4ddfa43
Invert if/for lines to avoid repetition
bctiemann Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions netbox/dcim/models/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1277,6 +1277,11 @@ def save(self, *args, **kwargs):
if not disable_replication:
create_instances.append(template_instance)

# Set default values for any applicable custom fields
if cf_defaults := CustomField.objects.get_defaults_for_model(component_model):
for component in create_instances:
component.custom_field_data = cf_defaults

if component_model is not ModuleBay:
component_model.objects.bulk_create(create_instances)
# Emit the post_save signal for each newly created object
Expand Down
Loading