17686 config option for disk divider #18011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
|
Would love to see this merged, running behind on v4.0 because of dependencies on netbox. |
|
Would love to see this merged, too. |
Member
|
Can you rebase to main? |
DanSheps
requested changes
Feb 7, 2025
DanSheps
previously requested changes
Feb 7, 2025
DanSheps
removed
the
pending closure
arthanson
requested changes
Feb 18, 2025
Collaborator
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
These also need to be added to the documentation, configuration/miscellaneous.md
….com/Haeki/netbox into 17686-config_option_for_disk_divider
Collaborator
|
@Haeki is this ready for re-review? If so please toggle the re-request review (spinner) in the upper right next to my name. |
arthanson
requested changes
Mar 4, 2025
arthanson
approved these changes
Mar 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17686 Ability to select disk divider
I added two new config options to specify the divider used to calculate the disk and ram sizes in different units.
The default value is 1000 but can be changed to 1024 to get GiB instead of GB.
Those config values are used in the
humanize_megabytesmethod. I split this method into two separate methods, one for RAM and one for disk values. Additionally I added the disk config value to the disk migration so that users with GiB values get them converted to MiB.I tested the changes in my local environment and noticed no problems.
I'm open for feedback and I also didn't include any tests yet.