Fix parsing of extra_choices #17691
Merged
Fix parsing of extra_choices #17691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2024 21:27
bctiemann
pushed a commit
that referenced
this pull request
Oct 11, 2024
* Align strawberry resolver with expected return type * Align test data with expected representation of extra_choices in CustomFieldChoiceSet model --------- Co-authored-by: Griffin Ellis <[email protected]>
jeremystretch
pushed a commit
to alehaa/netbox
that referenced
this pull request
Oct 11, 2024
* Align strawberry resolver with expected return type * Align test data with expected representation of extra_choices in CustomFieldChoiceSet model --------- Co-authored-by: Griffin Ellis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17562
Updates extra_choices to be a list of a list of strings which is what Django reports as the relevant types at each level. In addition, it seems some of the test data for extra_choices was a list of strings instead of a nested list.
The form code in CustomFieldChoiceSetForm automatically takes single-items and creates a label so there is a list of tuples being passed into the model.