Skip to content

Fixes: #17566 - Fix issue Job.get_absolute_url() to prevent exception being thrown if no object_type is set #17661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Fixes: #17566 - Fix issue Job.get_absolute_url() to prevent exception being thrown if no object_type is set #17661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57e3f41
Fixes: #17566 - Fix issue `Job.get_absolute_url()` to prevent excepti…
DanSheps Oct 2, 2024
abd1107
Add back whitespace after statements
DanSheps Oct 2, 2024
ae51e7d
Remove whitespace. Change to if statement
DanSheps Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions netbox/core/models/jobs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,10 +118,11 @@ def __str__(self):

def get_absolute_url(self):
# TODO: Employ dynamic registration
if self.object_type.model == 'reportmodule':
return reverse(f'extras:report_result', kwargs={'job_pk': self.pk})
if self.object_type.model == 'scriptmodule':
return reverse(f'extras:script_result', kwargs={'job_pk': self.pk})
if self.object_type:
if self.object_type.model == 'reportmodule':
return reverse(f'extras:report_result', kwargs={'job_pk': self.pk})
elif self.object_type.model == 'scriptmodule':
return reverse(f'extras:script_result', kwargs={'job_pk': self.pk})
return reverse('core:job', args=[self.pk])

def get_status_color(self):
Expand Down