Skip to content

Conversation

@arthanson
Copy link
Collaborator

Fixes: #17558

Editing custom field choice set my_choice_set | NetBox 2024-09-24 09-55-19

@arthanson arthanson changed the title DRAFT: 17558 raise validation error if removing choice from choiceset that i… 17558 raise validation error if removing choice from choiceset that i… Sep 24, 2024
@arthanson arthanson marked this pull request as ready for review September 24, 2024 19:53
@arthanson arthanson marked this pull request as draft September 25, 2024 15:14
@arthanson arthanson changed the title 17558 raise validation error if removing choice from choiceset that i… DRAFT: 17558 raise validation error if removing choice from choiceset that i… Sep 25, 2024
@arthanson arthanson changed the title DRAFT: 17558 raise validation error if removing choice from choiceset that i… 17558 raise validation error if removing choice from choiceset that i… Sep 25, 2024
@arthanson arthanson marked this pull request as ready for review September 25, 2024 15:50
@arthanson arthanson changed the title 17558 raise validation error if removing choice from choiceset that i… 17558 raise validation error if removing used choice from choiceset Sep 25, 2024
@arthanson arthanson changed the title 17558 raise validation error if removing used choice from choiceset 17558 raise validation error if removing used choice from ChoiceSet Sep 25, 2024
@jeremystretch jeremystretch merged commit a9fee5c into develop Sep 30, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 17558-custom-field branch September 30, 2024 17:17
bctiemann pushed a commit that referenced this pull request Oct 11, 2024
…17591)

* 17558 raise validation error if removing choice from choiceset that is currently used

* 17558 raise validation error if removing choice from choiceset that is currently used

* 17558 raise validation error if removing choice from choiceset that is currently used

* 17558 add tests

* 17558 add tests

* Tightened up choice evaluation logic a bit; cleaned up test

---------

Co-authored-by: Jeremy Stretch <[email protected]>
jeremystretch added a commit to alehaa/netbox that referenced this pull request Oct 11, 2024
…etbox-community#17591)

* 17558 raise validation error if removing choice from choiceset that is currently used

* 17558 raise validation error if removing choice from choiceset that is currently used

* 17558 raise validation error if removing choice from choiceset that is currently used

* 17558 add tests

* 17558 add tests

* Tightened up choice evaluation logic a bit; cleaned up test

---------

Co-authored-by: Jeremy Stretch <[email protected]>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Removal of an option in a CustomFieldChoice does not update objects with the choiceset and the option selected

3 participants