Fixes: #15408 - Add primary_ip4 and primary_ip6 to bulk import form for VDC #17509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Sep 17, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
The querysets for primary_ip4 and primary_ip6 need to be limited to IP addresses assigned to an interface on the specified device.
Contributor
Author
|
Added queryset filtering. |
arthanson
approved these changes
Sep 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15408
Adds
primary_ip4andprimary_ip6to VirtualDeviceContextImportForm.Uses
addressas the accessor field.