Skip to content

Conversation

@DanSheps
Copy link
Member

Fixes: #17492 - Change methods on NetBox*HyperlinkedIdentityField to use get_viewname

  • Adjust method to pass model instead of app_name and model_name
  • Adjust methods to use get_viewname

@DanSheps DanSheps requested a review from arthanson September 13, 2024 17:42
@DanSheps DanSheps self-assigned this Sep 13, 2024
@@ -1,5 +1,8 @@
from django.utils.translation import gettext_lazy as _
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, this is to fix an error my IDE was showing that we were using _ without importing it

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit 893adef into develop Sep 17, 2024
@jeremystretch jeremystretch deleted the 17492-swap-to-get_viewname branch September 17, 2024 13:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When inheriting NetBoxModelSerializer without defining an override for the url attribute, an exception is thrown

3 participants