Skip to content

Fixes: #17437 - Fix exception when saving interface-template with bridged interface #17456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixes: #17437 - Fix exception when saving interface-template with bridged interface #17456

wants to merge 1 commit into from

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Sep 11, 2024 •
edited
Loading

Fixes: #17437 - Fix exception when saving interface-template with bridged interface

  • Return None if NoReverseMatch found from self.reverse with BaseNetBoxHyperlinkedIdentityField.get_url

@DanSheps
Fixes: #17452 - Return None is NoReverseMatch found from self.reverse…
1e089d8 
… with BaseNetBoxHyperlinkedIdentityField.get_url
@DanSheps DanSheps changed the title Fixes: #17452 - Fix exception when saving interface-template with bridged interface Fixes: #17437 - Fix exception when saving interface-template with bridged interface Sep 12, 2024
@DanSheps DanSheps linked an issue Sep 12, 2024 that may be closed by this pull request
"No reverse for interfacetemplate" when saving a bridged interface #17452
Closed
@DanSheps DanSheps self-assigned this Sep 12, 2024
@jeremystretch
Copy link
Member

jeremystretch commented Sep 12, 2024 •
edited
Loading

NetBoxURLHyperlinkedIdentityField should always return a valid URL. If it doesn't, that's an indication that it shouldn't be included on the serializer. display_url needs to be removed from NestedInterfaceTemplateSerializer. We also need to fix the filter names set on the bridge form field. I've submitted alternate PR #17470 to address both changes.

@DanSheps DanSheps deleted the 17452-fix-no-reverse-for-interfacetemplate branch September 12, 2024 14:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson Awaiting requested review from arthanson

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees

@DanSheps DanSheps

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"No reverse for interfacetemplate" when saving a bridged interface Error when making an interface bridge on an intarface template of module type

3 participants

@DanSheps @jeremystretch