Skip to content

Conversation

@jeremystretch
Copy link
Member

Fixes: #17256

  • Convert VLANGroupForm to use a single dynamically-rendered scope field
  • Ditch an entire TypeScript module dedicated to displaying the old form 🎉

Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not working for me, I switched branches to this, cleared cache and reloaded then go to add a VLan Group, selecting scope-type to location doesn't change the form:

Add a new VLAN group | NetBox 2024-08-26 15-18-57

@jeremystretch
Copy link
Member Author

Changing the scope type should reset the list of choices in the "scope" field below it. (We're only using a single field now with a selector modal, regardless of the type.)

Copy link
Collaborator

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if an issue - but if you edit and change the scope-type the scope is not cleared, so if you have id's between the different tables that are the same you will automatically get the item in the new table with the same id. Not sure if it would be better to clear the scope on scope-type change?

@jeremystretch jeremystretch merged commit c2d67fa into develop Aug 27, 2024
@jeremystretch jeremystretch deleted the 17256-vlangroup-scope-selector branch August 27, 2024 17:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VLAN group scope selection fails for languages other than English

3 participants