Fixes: #16905 - Allow filtering on Device Status in InventoryItemTable #17260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nventoryItemTable
bctiemann
changed the title
jeremystretch
requested changes
Aug 26, 2024
| def get_absolute_url(self): | ||
| return reverse('dcim:inventoryitem', kwargs={'pk': self.pk}) | ||
|
|
||
| def get_device_status_color(self): |
Member
There was a problem hiding this comment.
We probably want to avoid introducing "proxy" methods that only exist to return the value of an attribute of some related object. Instead, maybe we can refactor ChoiceFieldColumn to accept a custom function for determining the appropriate color. Then we could do something like this:
device_status = columns.ChoiceFieldColumn(
accessor=tables.A('device__status'),
verbose_name=_('Device Status'),
color=lambda x: x.device.get_status_color()
)
Contributor
Author
There was a problem hiding this comment.
I like where this is going. Let me know if you think the preference order I've got here looks right to you -- it takes the color callable first if provided, then falls back to the try-except of get_FOO_color as before.
…efactor ChoiceFieldColumn to support a "color" callable allowing get_FOO_color behavior to be overridden
jeremystretch
requested changes
Aug 28, 2024
jeremystretch
requested changes
Aug 28, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
We should include tests for the device_status filters for all relevant models in dcim/tests/test_filtersets.py.
jeremystretch
approved these changes
Aug 29, 2024
jeremystretch
deleted the
16905-inventoryitemlist-filter-by-device-status
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16905 Allow filtering on Device Status in InventoryItemTable
Adds
device_statusas a filter field in Inventory Item list view, and associated filter inInventoryItemFilterSet.