Skip to content

Conversation

@arthanson
Copy link
Collaborator

Fixes: #16946

@arthanson arthanson changed the title DRAFT: 16946 raise error if filterset is not valid 16946 raise error if filterset is not valid Jul 29, 2024
@arthanson arthanson marked this pull request as ready for review July 29, 2024 14:58
@arthanson arthanson requested a review from jeremystretch July 29, 2024 14:58
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test for this fix to GraphQLTestCase?

@arthanson arthanson changed the title 16946 raise error if filterset is not valid 16946 return empty queryset if filterset is not valid Aug 26, 2024
@jeremystretch jeremystretch merged commit 3fee28c into develop Aug 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
@jeremystretch jeremystretch deleted the 16946-graphql-filter-error branch December 3, 2024 14:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GraphQL API returns all object if given filter is invalid

3 participants