Fixes #16760: datasource git on local file system fails #16872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Jul 10, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks for taking this on @thefriendlynet! I've just tweaked your fix to only add the quiet & depth arguments if using a remote URL (rather than removing them if not).
Contributor
Author
Perfect, I wasn't quite sure about the proper direction for the fix, hence my question in the issue. |
jeremystretch
added a commit
that referenced
this pull request
Jul 26, 2024
* Fixes #16760: datasource git on local file system fails * Fixes #16760: datasource git on local file system fails * Set depth & quiet parameters only if using a remote URL --------- Co-authored-by: Jeremy Stretch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16760
Datasource git on local file system fails with SyncError("Fetching remote data failed (TypeError): LocalGitClient.init() got an unexpected keyword argument 'quiet'")