fixed #16847: updated font #16848
fixed #16847: updated font #16848
Conversation
|
It is really bad practice to not define any fallback fonts. Instead, I would suggest using |
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
As mentioned by sleepinggennius, the font needs to be local - NetBox must be able to run without outside internet connection.
… font as fallback
|
Thanks for the feedback. I've added fallbacks and added a font package for Plus Jakarta Sans. I've used fontsource as typefaces is deprecated, does not have the font and recommends using fontsource. |
There was a problem hiding this comment.
I've noticed some odd spacing issues with the Jakarta font. For example, there is considerably less vertical space between the title and subtitle texts in the example below, even though element margin & padding remain unchanged. The subtitle text is also considerably larger in Jakarta, even though both are computed as 12px.
Original (Inter):
Modified (Jakarta):
|
I believe the slight size different in the font faces is okay, but I have added some padding to the page header title to give it some breathing room. |
* 16649 general contrast issues (#16759) * fixes #16647: navigation contrast issues updated * fixes #16651: table contrast issues new * fixed #16649: general contrast issues * fixes #16649: feedback changes --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Andrew Gormley <[email protected]> * 16648 dashboard contrast issues (#16824) * fixed #16648: dashboard contrast issues * reinstate amendment to 16649 * fixed #16648: created gridstack override and removed inline bug fix --------- Co-authored-by: Andrew Gormley <[email protected]> * fixed #16853: accessibility issues * fixed #16847: updated font (#16848) * fixed #16847: updated font * fixed #16847: changed font to local and added current font as fallback * fixed #16847: removed inter and added padding to page header --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * 16849 document hierarchy issues (#16875) * fixed #16849: h elements not in sequential order * fixed #16849: Lists do not contain only li elements * fixed #16849: fixed h hierarchy on rack object pages * Remove standalone h5 classes * Remove unnecessary line breaks --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * 16650 button contrast issues (#16845) * fixed #16650: button contrast issues * fixed #16650: green bg text contrast issue * Revert errant JS resource updates * Revert custom button colors * Fix indentation --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * 16907 web UI refresh (#16915) * closes #16907: web ui refresh * closes #16907: changed default widget color to primary color * closes #16907: removed comma * Revert dashboard widget color changes * Rename logo images for consistency * Restore original dashboard widget config * Remove .navbar-brand-autodark from logo * Restore logo file names --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * 16394 distinguish product edition (#16924) * closes #16907: web ui refresh * closes #16907: changed default widget color to primary color * closes #16907: removed comma * closes #16394: distinguish product edition * Revert dashboard changes * Clean up redundant styling (merge error) * removed labs logo and added sub text for all editions * fixed motif bug * Fix "flashing" of side nav under dark mode * Use title case for edition label * altered edition text style --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * Query release features to toggle commercial theme * fixes dark mode primary button contrast issue * fixes #16913: hidden admin nav link (#16978) Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * fixed 16852: misc accessbility problems (#16977) * fixed 16852: misc accessbility problems * Restore tooltip text * Add translation support * Add missing i18n --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * fixes issues in #16850 (#16986) * fixes issues in #16850: issue 3 and 5 * Add link text for 'clear' button on table column * Translate aria label --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Jeremy Stretch <[email protected]> * Use alternate footer links for commercial releases * Remove Inter font * Adjust base font weight to 500 * Retain default text color for hyperlinks inside tables * Logo & edition cleanup * Move dashboard styling * Misc cleanup * Remove unused styles * Misc cleanup & refactoring --------- Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Andrew Gormley <[email protected]> Co-authored-by: Andrew Gormley <[email protected]>
4 participants
Fixes: #16847
Updated font to Plus Jakarta Sans