Skip to content

Fixes #16779: Fix saved filter selection for child object lists #16789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

Fixes #16779: Fix saved filter selection for child object lists #16789

merged 2 commits into from
Jul 3, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Jul 2, 2024

Fixes: #16779

  • Add filterset_form attribute on ObjectChildrenView
  • Extend ObjectChildrenView to instantiate filter form
  • Define individual filter forms on all relevant ObjectChildrenView subclasses
  • Tweak template to hide saved filters selector if no filter form has been defined

@jeremystretch jeremystretch merged commit b18a6b7 into develop Jul 3, 2024
@jeremystretch jeremystretch deleted the 16779-objectchildrenview-saved-filters branch July 3, 2024 12:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Saved filters not available on child object list views

2 participants

@jeremystretch