Do not delete all search indexes when reindexing specific models #16755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clear all indexes only if neither --lazy nor a list of models are specified for "manage.py reindex" * Otherwise, clear the index for a model immediately before rebuilding it
jeremystretch
requested changes
Jun 30, 2024
| if model_labels: | ||
| self.stdout.write(f'clearing {cached_count} cached values... ', ending='') | ||
| self.stdout.flush() | ||
| search_backend.clear(object_types=[content_type]) |
Member
There was a problem hiding this comment.
We want to keep the cache clearing logic before and separate from the indexing logic. The call to search_backend.clear() above (originally line 73) should be wrapped in a conditional that checks for model_labels and passes either the appropriate content types or None. The indexing logic can then be retained in its original form.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--lazynor a list of models are specified for "manage.py reindex"Fixes: #16747