SSO: custom name for identity providers #16732
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerrykan
reviewed
Jul 3, 2024
netbox/account/views.py
Outdated
|
|
||
| icon_name = None | ||
| icon_img = None | ||
| if '://' in icon_source: |
There was a problem hiding this comment.
This will raise an exception if icon_source is None. It should probably be:
if icon_source and '://' in icon_source:
Contributor
Author
There was a problem hiding this comment.
Good catch, indeed. Patched in my amended commit.
|
I've tested this with a patched v4.0.6 instance and it seems to do the job (ignoring the one bug related to It would be good to see this merged. |
tobast
force-pushed
the
tbastian/custom_idp_name
branch
from
5a17893 to
23beda5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15375 -- allows a user to customize the display aspect of social login providers (SSO and such).
This PR is separated into two commits on purpose.
The first one fixes #15375 and adds relevant documentation. Users may specify in their configuration
SOCIAL_AUTH_BACKEND_ATTRS, which override the display name of a social login provider, based on thenameattribute of theREMOTE_AUTH_BACKENDclass.The second one allows to use an arbitrary URL as the identity provider's image. Using mdi icons works well for eg. Github social auth, but does not allow for corporate branding of an internal SSO (which is often expected by users).