Skip to content

Closes #16307: Enable calling log_* methods on Script without a log message #16697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2024
Merged

Closes #16307: Enable calling log_* methods on Script without a log message #16697

merged 1 commit into from
Jun 24, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Jun 24, 2024

Fixes: #16307

  • Convert the message argument on all Script log_*() methods to an optional keyword argument
  • Record test method logs only if message is not null/empty
  • Update documentation

@jeremystretch jeremystretch requested a review from arthanson June 24, 2024 13:41
@jeremystretch jeremystretch mentioned this pull request Jun 24, 2024
Closed
@jeremystretch jeremystretch merged commit 8b62e40 into develop Jun 24, 2024
@jeremystretch jeremystretch deleted the 16307-scripts-log-message-optional branch June 24, 2024 14:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restore ability for scripts to be able to log_success without generating a message

3 participants

@jeremystretch @arthanson