Skip to content

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Jun 3, 2024

Fixes: #16083 - Add font-variant-ligatures setting to disable ligatures on chromium

  • Add font-variant-ligatures setting and set to none in _tabler.scss overrides file.
  • Bundle styles

@DanSheps DanSheps requested a review from jeremystretch June 3, 2024 02:10
@DanSheps DanSheps self-assigned this Jun 3, 2024
@DanSheps DanSheps requested a review from jeremystretch June 3, 2024 14:45
@jeremystretch
Copy link
Member

Seems like it's still happening inside input fields. @DanSheps could you take a look? Seems fine when rendered as static text on the page. (This is on Firefox btw.)

screenshot

@DanSheps
Copy link
Member Author

DanSheps commented Jun 3, 2024

Seems like it's still happening inside input fields. @DanSheps could you take a look? Seems fine when rendered as static text on the page. (This is on Firefox btw.)

Looks like chrome has a specific override for <input> within the browser CSS. Likely the same in Firefox. I added <input> to the override file

@jeremystretch
Copy link
Member

There are other elements (e.g. <textarea>) where this also needs to be applied, so I simplified it to a global rule.

Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit 8ab9afb into develop Jun 4, 2024
@jeremystretch jeremystretch deleted the 16083-fix-font-ligatures branch June 4, 2024 13:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird font style when doing name that contains "<number>x<number>"

3 participants