Fixes #16274: Dark mode highlight color #16355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@ljarasius please do a yarn bundle and check-in the compiled front-end files. |
Contributor
Author
Apologies, done :) |
|
@ljarasius Thank you!!!! |
jeremystretch
requested changes
Jun 4, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
While this improves contrast under dark mode, the highlight color in light mode is now too dark:
Original
Modified
Could you please adjust your change so that it applies only under dark mode?
Contributor
Author
|
Updated :) Noting that a refresh of the browser is required when switching between dark and light mode for it to change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16274
Tabler has an alpha value for .16 by default for the selection background colour. Increasing this makes the distinction much clearer, .48 chosen as it is "3 times" more and seems to be a good place to start. Light mode is still clear with this change.
Before:
After:
