Skip to content

Conversation

@Julio-Oliveira-Encora
Copy link
Contributor

Fixes: #16315

Replaced /api/extras/content-types/ with /api/extras/object-types/ for JournalEntryFilterForm and ObjectChangeFilterForm.

…pes/" for JournalEntryFilterForm and ObjectChangeFilterForm.
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we don't want to return an unfiltered list of object types. Instead, we can change these fields to instances of ContentTypeMultipleChoiceField; see CustomLinkFilterForm for an example:

object_type = ContentTypeMultipleChoiceField(
label=_('Object types'),
queryset=ObjectType.objects.with_feature('custom_links'),
required=False
)

@jeremystretch jeremystretch merged commit 87109f5 into netbox-community:develop Jun 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cant filter changelog by object type (no results found)

2 participants