Skip to content

Extend STORAGE_BACKEND config to support Swift #16319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 8, 2024
Merged

Extend STORAGE_BACKEND config to support Swift #16319

merged 6 commits into from
Jul 8, 2024

Conversation

@XioNoX
Copy link
Contributor

@XioNoX XioNoX commented May 28, 2024

Fixes: #14554

@jeremystretch jeremystretch requested a review from arthanson May 28, 2024 13:03
@github-actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024

This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken.

@github-actions github-actions bot added the pending closure Requires immediate attention to avoid being closed for inactivity label Jun 13, 2024
@XioNoX
Copy link
Contributor Author

XioNoX commented Jun 13, 2024

@arthanson hello, is it possible to prevent the automatic closure? Thanks

jeremystretch
jeremystretch requested changes Jun 21, 2024
View reviewed changes
@jeremystretch jeremystretch requested review from jeremystretch and removed request for arthanson June 21, 2024 14:22
@jeremystretch jeremystretch removed the pending closure Requires immediate attention to avoid being closed for inactivity label Jun 26, 2024
@XioNoX
Copy link
Contributor Author

XioNoX commented Jul 3, 2024

Hi @jeremystretch I still see "Changes requested", so I want to make sure nothing is blocked on me. Thanks.

jeremystretch
jeremystretch requested changes Jul 8, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XioNoX this should be good to go except for the inclusion of django.po; this file should be removed from the PR. (I tried to handle this myself but I don't have permission to push changes to your branch.)

XioNoX and others added 6 commits July 8, 2024 15:11
@XioNoX
Extend STORAGE_BACKEND config to support Swift
a79a67a 
Requires django-storage-swift >= 1.4.0 when used.

Bug: T310717
Change-Id: I67cf439e9152608cbba3a3de4173d54ba5fbddc2
@XioNoX @jeremystretch
Update system.md from suggestions
4399a15 
Co-authored-by: Jeremy Stretch <[email protected]>
@XioNoX @jeremystretch
Update settings.py from suggestions
21753b3 
Co-authored-by: Jeremy Stretch <[email protected]>
@XioNoX @jeremystretch
Update system.md from suggestions 2
d56ab5a 
Co-authored-by: Jeremy Stretch <[email protected]>
@XioNoX
Remove SWIFT storage from configuration_example.py
ad40f43
@XioNoX
Load swift config as global instead of monkey path
8256fef
@XioNoX
Copy link
Contributor Author

XioNoX commented Jul 8, 2024

@XioNoX this should be good to go except for the inclusion of django.po; this file should be removed from the PR. (I tried to handle this myself but I don't have permission to push changes to your branch.)

I think it's good now :) thanks

jeremystretch
jeremystretch approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @XioNoX!

@jeremystretch jeremystretch merged commit 22348cd into netbox-community:develop Jul 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend STORAGE_BACKEND to support swift

2 participants

@XioNoX @jeremystretch