Skip to content

Conversation

@devon-mar
Copy link
Contributor

Fixes: #16173

Fixes TypeError when paginate.per_page user preference is "".
This happens when the user clears the per page preference which sets it to the empty string, causing
per_page to be a string instead of an integer.

@devon-mar devon-mar changed the title Fix pagination when pagination.per_page is "" 16173 - Fix pagination when pagination.per_page is "" May 18, 2024
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devon-mar!

@jeremystretch jeremystretch merged commit 5e92dac into netbox-community:develop May 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clearing page length user preference breaks pagination

2 participants