Skip to content

Conversation

@arthanson
Copy link
Collaborator

@arthanson arthanson commented May 17, 2024

Fixes: #16050

Removed module name customization from docs as this doesn't look like it worked in v3.7 after discussion with Jeremy.

@arthanson arthanson marked this pull request as ready for review May 17, 2024 16:27
@arthanson arthanson requested a review from jeremystretch May 17, 2024 16:27
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to address the script name & description but not the module name. Can we fix that as well?

@samk-acw
Copy link
Contributor

I tried these changes manually on my server and had issue with script.python_class.description - If a script has a field called "description" it will throw an exception:

<class 'AttributeError'>
'StringVar' object has no attribute 'strip'

Seems like the description attribute (probably name and any other attributes) get overwritten with the field vars if there's a field with the same name
Changing it to script.python_class.Meta.description resolved it for me.

@arthanson arthanson requested a review from jeremystretch June 4, 2024 15:35
@jeremystretch
Copy link
Member

We ended up dropping support for renaming the module itself, as it hasn't work for some time and is ultimately somewhat dangerous and confusing.

@jeremystretch jeremystretch merged commit 8f87c72 into develop Jun 6, 2024
@jeremystretch jeremystretch deleted the 16050-script-name branch June 6, 2024 13:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Scripts - Module & Script Attributes

4 participants