Skip to content

16138 fix user/group permissions #16152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 17, 2024
Merged

16138 fix user/group permissions #16152

merged 3 commits into from
May 17, 2024

Conversation

@arthanson
Copy link
Collaborator

@arthanson arthanson commented May 15, 2024 •
edited
Loading

Fixes: #16138

Fixes several issues with user/group permissions:

  1. in menu - update to check the correct permissions
  2. in constants - change so correct permissions are shown in the Permissions form "Object Type" field
  3. add a migration to change any permissions set for auth.groups to users.group. Note: users does not need to be changed as the content-type was migrated.

@arthanson arthanson changed the title DRAFT: 16138 fix user/group permissions 16138 fix user/group permissions May 15, 2024
@arthanson arthanson marked this pull request as ready for review May 15, 2024 19:33
@arthanson arthanson requested a review from jeremystretch May 15, 2024 19:33
jeremystretch
jeremystretch approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit d060b38 into develop May 17, 2024
@jeremystretch jeremystretch deleted the 16138-user-group branch May 17, 2024 19:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User and Group object types missing from permissions in 4.0

3 participants

@arthanson @jeremystretch