Skip to content

Fixes: #16022 - Fix Script and Report Migration #16033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2024
Merged

Fixes: #16022 - Fix Script and Report Migration #16033

merged 1 commit into from
May 8, 2024

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented May 8, 2024

Fixes: #16022 - Fix Script and Report Migration

  • Return an empty dict if import failes. This results in no scripts being created (ScriptModule still exists until deleted)

@DanSheps DanSheps requested a review from arthanson May 8, 2024 13:45
@jeremystretch jeremystretch merged commit d7d97b1 into develop May 8, 2024
@jeremystretch jeremystretch deleted the 16022-fix-migration branch May 8, 2024 17:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

migration failure if old scripts exist in db that no longer exist on disk (0109_script_model)

4 participants

@DanSheps @arthanson @jeremystretch