Skip to content

Fixes #15925: Fix rendering of cable traces to circuit terminations #15938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Fixes #15925: Fix rendering of cable traces to circuit terminations #15938

merged 1 commit into from
May 3, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented May 3, 2024

Fixes: #15925

  • Order objects by their string representation, rather than by name
  • Extend cable path tests to call CableTraceSVG.render() for additional coverage

@jeremystretch jeremystretch requested a review from arthanson May 3, 2024 12:36
@jeremystretch jeremystretch merged commit c8a9bc0 into develop May 3, 2024
@jeremystretch jeremystretch deleted the 15925-fix-tracing-circuits branch May 3, 2024 14:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arthanson arthanson arthanson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rendering of cable trace broken after upgrading from 3.7.6 to 3.7.7

3 participants

@jeremystretch @arthanson