Fixes #15917: slim-select-pagination-bug-fix : fixed several bugs related to slim select #15918
Conversation
select search box gui element 1. If user enters a search text in the filter text box, the user will not be able to scroll to the next page. That is the user will only be able to see the first page of returned item with a none empty search string. 2. User will not be able to select an item returned from search query if user clicks reload after a dynami search. When the user is able to load a second page, the user will be able to select an item from the third+ page if previous bug is fixed.
MaxBear
changed the title
|
This library has been completely removed in NB v4, so this would no longer apply. @MaxBear Also, FYI - While we greatly appreciate the work here, please open the issue before submitting a PR, there may be discussion needed around any proposed solution or it may be superseded by other work. |
|
@arthanson The issue and the fix still apply for users not upgraded to beta v4 release. I have already opened the issue , otherwise, i won't have the fix id . By this do you mean one should only submit a pr after you have decided to submit a pr for this fix or not ? |
|
@MaxBear Sorry, you submitted the issue at just the wrong time (no fault of yours) we just did the last release of 3.x before the 4.x release so there wasn't a release to get this in. That said, we are currently evaluating whether we might cut one more 3.x release and if we do we will re-evaluate potentially including your PR assuming there are not any changes needed. |
…ated to slim select (#15918) * slim-select-pagination-bug-fix : fixed several bugs related to slim select search box gui element 1. If user enters a search text in the filter text box, the user will not be able to scroll to the next page. That is the user will only be able to see the first page of returned item with a none empty search string. 2. User will not be able to select an item returned from search query if user clicks reload after a dynami search. When the user is able to load a second page, the user will be able to select an item from the third+ page if previous bug is fixed. * Recompile static assets --------- Co-authored-by: Jeremy Stretch <[email protected]>
3 participants
Fixes: #15917