Skip to content

Added assigned_object_type in prefetch for api view IPAddressViewSet #15886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2024
Merged

Added assigned_object_type in prefetch for api view IPAddressViewSet #15886

merged 1 commit into from
Apr 29, 2024

Conversation

@mulmat
Copy link
Contributor

@mulmat mulmat commented Apr 29, 2024

Fixes: #15845

Adds assigned_object_type to prefetch in order to avoid N+1 issue in /api/ipam/ip-addresses/

@mulmat mulmat mentioned this pull request Apr 29, 2024
Closed
@jeremystretch
Copy link
Member

jeremystretch commented Apr 29, 2024

Thanks @mulmat!

@jeremystretch jeremystretch merged commit 851b4cc into netbox-community:develop Apr 29, 2024
@mulmat mulmat deleted the 15845-list-ipaddresses-api-n1-issue branch April 29, 2024 14:50
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

N+1 issue on the /api/ipam/ip-addresses/ endpoint

2 participants

@mulmat @jeremystretch