Skip to content

Fixes: #15502 - Correct exception on IP import form when VM is target #15508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2024
Merged

Fixes: #15502 - Correct exception on IP import form when VM is target #15508

merged 1 commit into from
Apr 3, 2024

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Mar 22, 2024

Fixes: #15502 - Correct exception on IP import form when VM is target

  • Modify save() to use .get() around cleaned data when determining parent

@DanSheps DanSheps requested a review from jeremystretch March 22, 2024 15:28
@DanSheps DanSheps self-assigned this Mar 22, 2024
@DanSheps DanSheps added type: bug A confirmed report of unexpected behavior in the application severity: low Does not significantly disrupt application functionality, or a workaround is available and removed type: bug A confirmed report of unexpected behavior in the application severity: low Does not significantly disrupt application functionality, or a workaround is available labels Mar 22, 2024
jeremystretch
jeremystretch approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit 7d54357 into develop Apr 3, 2024
@jeremystretch jeremystretch deleted the 15502-fix-primary-ip-vm-import branch April 3, 2024 12:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

@DanSheps DanSheps

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot set Primary IP for VM when Importing IP with CSV

3 participants

@DanSheps @jeremystretch