Skip to content

Conversation

@arthanson
Copy link
Collaborator

Fixes: #15353

Better error handling if the script module can't load (for example a syntax error). Instead of crashing an error message of what error occurred is displayed.

Monosnap NewBranchScript | NetBox 2024-03-14 15-07-39

@arthanson arthanson requested a review from jeremystretch March 14, 2024 22:30
@arthanson arthanson marked this pull request as ready for review March 18, 2024 14:58
@jeremystretch
Copy link
Member

This bug was reported in v3.7.3 but the PR targets feature. We should strive to fix this in v3.7 unless it proves infeasible.

@arthanson
Copy link
Collaborator Author

@jeremystretch I changed it for 4 as the script class and template changed in 4 so there would be merge issues.

@jeremystretch jeremystretch changed the base branch from feature to develop May 17, 2024 16:32
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 58da5c1 into develop May 17, 2024
@jeremystretch jeremystretch deleted the 15353-script-error branch May 17, 2024 18:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unhelpful message with custom script errors - AttributeError:'NoneType' object has no attribute 'full_name'

3 participants