Skip to content

Fixes #15126: group field should be optional when creating VPN tunnel via REST API #15136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2024
Merged

Fixes #15126: group field should be optional when creating VPN tunnel via REST API #15136

merged 1 commit into from
Feb 13, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Feb 13, 2024

Fixes: #15126

  • Correct the group field on TunnelSerializer
  • Update the API test suite to test for creation of a tunnel with no group assignment

@jeremystretch jeremystretch merged commit df91092 into develop Feb 13, 2024
@jeremystretch jeremystretch deleted the 15126-fix-tunnel-group branch February 13, 2024 14:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanSheps DanSheps Awaiting requested review from DanSheps

1 more reviewer

@abhi1693 abhi1693 abhi1693 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

API call to add VPN tunnel fails: group field is required

3 participants

@jeremystretch @abhi1693