Fixes: #14839 - Check for tunnel termination type in data and instance in addition to intially passed data. #14995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Feb 1, 2024
netbox/vpn/forms/model_forms.py
Outdated
Comment on lines
269
to
275
| if ( | ||
| initial and initial.get('type') == TunnelTerminationTypeChoices.TYPE_VIRTUALMACHINE | ||
| ) or ( | ||
| self.data and self.data.get('type') == TunnelTerminationTypeChoices.TYPE_VIRTUALMACHINE | ||
| ) or ( | ||
| self.instance.pk and isinstance(self.instance.termination.parent_object, VirtualMachine) | ||
| ): |
Member
There was a problem hiding this comment.
Run-on conditionals like this are not viable from a maintainability standpoint. Please have a look at how we've used the get_field_value() utility function in other forms to avoid this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14839