Skip to content

Fixes #14703: Catch exceptions when rendering dashboard and revert to default #14903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fixes #14703: Catch exceptions when rendering dashboard and revert to default #14903

merged 1 commit into from
Jan 24, 2024

Conversation

@jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Jan 23, 2024

Fixes: #14703

  • Extend get_default_dashboard() to allow passing a specific dashboard configuration
  • Wrap the call to get_layout() in a try/except and fall back to the (hard-coded) default config

@DanSheps DanSheps self-requested a review January 24, 2024 18:16
DanSheps
DanSheps approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Tested followinng repro steps in #14703

@jeremystretch jeremystretch merged commit 487f1cc into develop Jan 24, 2024
@jeremystretch jeremystretch deleted the 14703-invalid-dashboard branch January 24, 2024 22:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DanSheps DanSheps DanSheps approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User Dashboard can become permanently broken when misconfiguring DEFAULT_DASHBOARD

3 participants

@jeremystretch @DanSheps