Fixes #14755: ValueError in web UI after REST API accepts invalid cus… #14804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…epts invalid custom-field choice-set data
jeremystretch
requested changes
Jan 16, 2024
jeremystretch
approved these changes
Jan 19, 2024
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks @Julio-Oliveira-Encora!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tom-field choice-set data
Fixes: #14755
Currently, the endpoint "custom-field-choice-sets" accepts one element each (should be two elements each). I changed the Serializer to check the payload and return 400 if it's malformed.