Skip to content

Conversation

@markkuleinio
Copy link
Contributor

@markkuleinio markkuleinio commented Dec 16, 2023

Fixes: #14507

NetBox version is fetched from netbox/netbox/settings.py (the script already cd'd to the location of upgrade.sh = the top-level directory of NetBox).

@DanSheps
Copy link
Member

This might make sense to rebase to feature, as we are making a pretty big change to how the upgrade script runs (pause). Thoughts?

@markkuleinio markkuleinio changed the base branch from develop to feature December 18, 2023 17:03
@markkuleinio
Copy link
Contributor Author

Sounds reasonable, I rebased the PR to feature (unless I failed it somehow but looks good I think).

@markkuleinio markkuleinio changed the base branch from feature to develop December 21, 2023 06:25
@markkuleinio markkuleinio changed the title Add NetBox version output and pause in upgrade.sh Add NetBox version output in upgrade.sh Dec 21, 2023
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markkuleinio!

@jeremystretch jeremystretch merged commit c1cf037 into netbox-community:develop Dec 21, 2023
@markkuleinio markkuleinio deleted the print-version branch December 22, 2023 06:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print NetBox version when running upgrade.sh

3 participants