Skip to content

Fixes #14482 - Fix validation error when primary IP is moved #14514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 28, 2023
Merged

Fixes #14482 - Fix validation error when primary IP is moved #14514

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f8f05a
Fix validation when primary IP is moved.
DanSheps Dec 13, 2023
366351d
Fix views test
DanSheps Dec 13, 2023
6aa4670
Work on excluding assigned_objects
DanSheps Dec 18, 2023
b9b24d9
Modify clean() on model and form to properly catch error
DanSheps Dec 18, 2023
9374890
Fix test failure
DanSheps Dec 21, 2023
ec58b53
Fix test to check for PK
DanSheps Dec 21, 2023
2cc35b4
Remove model_form check
DanSheps Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions netbox/ipam/models/ip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,11 +864,9 @@ def clean(self):
is_primary = True

if is_primary and (parent != original_parent):
raise ValidationError({
'assigned_object': _(
"Cannot reassign IP address while it is designated as the primary IP for the parent object"
)
})
raise ValidationError(
_("Cannot reassign IP address while it is designated as the primary IP for the parent object")
)

# Validate IP status selection
if self.status == IPAddressStatusChoices.STATUS_SLAAC and self.family != 6:
Expand Down