14346 fix missing function call convert #14376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR netbox-community#13958 (commit 8224644) _get_report was modified to do the call on the variable without changing the call later on. This commit fixes that and removes the call on the variable. Signed-off-by: Josef Johansson <[email protected]>
candlerb
reviewed
Nov 30, 2023
| # Retrieve and run the Report. This will create a new Job. | ||
| module, report_cls = self._get_report(pk) | ||
| report = report_cls() | ||
| report = report_cls |
Contributor
There was a problem hiding this comment.
The value is no longer a report class, so maybe clearer to drop report_cls so it becomes:
module, report = self._get_report(pk)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #13958 (commit 8224644) _get_report was modified to do the call on the variable without changing the call later on.
Fixes: #14346
This commit fixes that and removes the call on the variable.