Adds selection custom field labels to UI #13974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
approved these changes
Oct 5, 2023
Member
jeremystretch
left a comment
jeremystretch
left a comment
There was a problem hiding this comment.
Thanks @sleepinggenius2!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13950
Adds a function to the
CustomFieldmodel to get the choice label for a given value, defaulting to the passed value if one cannot be found. Updates thecustomfield_valuetemplate tag to leverage the new function, as I could not find a way to call a function with an argument in the template without registering a new tag anyway. Updates therenderfunction of theCustomFieldColumnclass to leverage the new function, so that table columns are rendered properly. Please let me know if there is anywhere else in the UI where custom field values are rendered that I might have missed.