Skip to content

Service Bulk Import Form with IP Address Added #13911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Service Bulk Import Form with IP Address Added #13911

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
650783b
issue 13022 resolved, ipaddress added into bulk_import form
yash-pal1 Sep 27, 2023
518ee85
validation of ip address for device and virtual machine
Oct 10, 2023
9955864
error message modified
Oct 10, 2023
fc61630
error message modified
Oct 10, 2023
ade0eda
error message modified
Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion netbox/ipam/forms/bulk_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,10 +507,30 @@ class ServiceImportForm(NetBoxModelImportForm):
choices=ServiceProtocolChoices,
help_text=_('IP protocol')
)
ipaddresses = CSVModelMultipleChoiceField(
queryset=IPAddress.objects.all(),
required=False,
to_field_name='address',
help_text=_('IP Address'),
)

class Meta:
model = Service
fields = ('device', 'virtual_machine', 'name', 'protocol', 'ports', 'description', 'comments', 'tags')
fields = (
'device', 'virtual_machine', 'ipaddresses', 'name', 'protocol', 'ports', 'description', 'comments', 'tags')

def clean_ipaddresses(self):

device = self.cleaned_data.get('device')
virtual_machine = self.cleaned_data.get('virtual_machine')

for ip_address in self.cleaned_data.get('ipaddresses'):
if device and ip_address != device.primary_ip4:
raise forms.ValidationError(f"Device is not assigned to this {ip_address}")
if virtual_machine and ip_address != virtual_machine.primary_ip4:
raise forms.ValidationError(f"Virtual Machine is not assigned to this {ip_address}")

return self.cleaned_data


class L2VPNImportForm(NetBoxModelImportForm):
Expand Down