Skip to content

Add Hide Disconnected Button to Interface Summary, Remove Unused Table Caption - Closes #12732 #13900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

Add Hide Disconnected Button to Interface Summary, Remove Unused Table Caption - Closes #12732 #13900

merged 1 commit into from
Sep 26, 2023

Conversation

@stuntguy3000
Copy link
Contributor

@stuntguy3000 stuntguy3000 commented Sep 26, 2023

Closes: #12732

vmconnect_2023-09-26_15-24-53

This PR:

  1. Introduces a Hide Disconnected interfaces button
  2. Removes an unused table-caption description system (this might be controversial, but I could not identify any actual usage of this system and see no reason to keep it)

@jeremystretch
Copy link
Member

jeremystretch commented Sep 26, 2023

Removes an unused table-caption description system

AFAICT this is no longer used.

jeremystretch
jeremystretch approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stuntguy3000!

@jeremystretch jeremystretch merged commit 27297c7 into netbox-community:develop Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
@stuntguy3000 stuntguy3000 deleted the 12732-hideshow-connected-interfaces branch December 18, 2024 08:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Hide/Show Connected to Device Interface Summary Filter

2 participants

@stuntguy3000 @jeremystretch