Skip to content

13891 fix primary ip assignment if assigning ip #13892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2023
Merged

13891 fix primary ip assignment if assigning ip #13892

merged 1 commit into from
Sep 26, 2023

Conversation

@arthanson
Copy link
Collaborator

@arthanson arthanson commented Sep 25, 2023

Fixes: #13891

Fixes case where you are marking an IP address as primary while also assigning it.

@arthanson arthanson marked this pull request as ready for review September 25, 2023 21:03
jeremystretch
jeremystretch approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arthanson!

@jeremystretch jeremystretch merged commit 685ac5f into develop Sep 26, 2023
@jeremystretch jeremystretch deleted the 13891-primary-ip branch September 26, 2023 12:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

@abhi1693 abhi1693 Awaiting requested review from abhi1693

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't assign primary IP when editing and assigning existing IP address

3 participants

@arthanson @jeremystretch