Bugfixes for mark installed/mark planned button #13807
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes netbox-community#13712 and netbox-community#13806. Not super happy with the fix here, because it doesn't address the underlying problem, which is that the toggleConnection() typescript function hardcodes which CSS classes should be added/removed. Probably a more permanent fix would be to stop applying CSS classes on the table view, and instead apply attributes for cable/interface state, and then use CSS to apply colours based on interface state, but this is a quite involved process. But it does at least fix things in the here and now.
Contributor
Author
|
Let's hold off on this one for now, since this doesn't properly respect FIELD_CHOICES. I'm going to see if I can't come up with a better solution. |
Contributor
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further action is taken. |
github-actions
bot
added
the
pending closure
Contributor
|
This PR has been automatically closed due to lack of activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13712 and #13806.
Not super happy with the fix here, because it doesn't address the underlying problem, which is that the toggleConnection() typescript function hardcodes which CSS classes should be added/removed. Probably a more permanent fix would be to stop applying CSS classes on the table view, and instead apply attributes for cable/interface state, and then use CSS to apply colours based on interface state, but this is a quite involved process. But it does at least fix things in the here and now.