Skip to content

Fixes: #13682 - Fix custom field exceptions and validation #13685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 6, 2023
Merged

Fixes: #13682 - Fix custom field exceptions and validation #13685

merged 5 commits into from
Sep 6, 2023

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Sep 5, 2023

Fixes: #13682

Fix custom field exceptions and validation

  • Change self.message to err.message to properly reference nested exception
  • Change clean logic to set "default_value" to list for multiselect and multiobject
  • Change validation logic to deconstruct choice set tuple for select to only check the value

jeremystretch
jeremystretch requested changes Sep 5, 2023
View reviewed changes
@jeremystretch
Copy link
Member

jeremystretch commented Sep 6, 2023

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit 2d1457b into develop Sep 6, 2023
@jeremystretch jeremystretch deleted the 13682-fix-custom-field-selection-creation branch September 6, 2023 14:47
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch jeremystretch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cannot add a new custom field of type selection/multiple selection list

3 participants

@DanSheps @jeremystretch