-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Adds generic object children template #13388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jeremystretch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks! I think with a little further cleanup we should be able to simplify it even further and avoid any potentially breaking changes in plugins.
|
There is an issue with the cluster object views which requires more changes or we may have to revert the changes partially or fully for cluster views |
DanSheps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really dislike the tab_view.html template name. It does not properly convey what this view does (displays objectchildren lists)
Instead, I would propose we rename it to objectchildren_list.html to properly convey what this template actually does.
|
@DanSheps If you check the latest changes, the file was moved and renamed to |
Still doesn't address the fact that object_tab is overly generic, especially when this template can only be used to generate a list. As mentioned, I think The convention, which is mostly universal within the generics:
Doing all that gives you the template name (object.html, object_edit.html, object_delete.html, object_list.html) |
Fixes: #12110