Fixes asn_count on asn range #13049
Closed
Fixes asn_count on asn range #13049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+37
to
+40
| @extend_schema_field(OpenApiTypes.INT) | ||
| def get_asn_count(self, obj): | ||
| return obj.get_child_asns().count() | ||
|
|
Member
There was a problem hiding this comment.
There are two issues with this approach:
- It generates a separate query per object in the table.
- It prevents us from ordering the table by ASN count.
I've opened #13053 with a more complete (albeit more complex) solution. Please let me know what you think.
Member
|
Superseded by #13053 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13047
asn_countwas defined on the serializer but wasn't showing up in the resultsLinkedCountColumnwithTemplateColumndue to 2 reasons: