Skip to content

Fixes #12760 - Adds Vary header to prevent caching of HTMX requests #13028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2023
Merged

Fixes #12760 - Adds Vary header to prevent caching of HTMX requests #13028

merged 1 commit into from
Jun 29, 2023

Conversation

@DanSheps
Copy link
Member

@DanSheps DanSheps commented Jun 27, 2023

Fixes: #12760

  • Adds Vary header to CoreMiddleware to cause caching to depend on the URL and the HX-Request flag.

@DanSheps
Fixes #12760 - Adds Vary header to cause cache to be keyed based on U…
0fba417 
…RL and the HX-Request header (or lack thereof)
@DanSheps DanSheps requested a review from jeremystretch June 27, 2023 14:59
@jeremystretch
Copy link
Member

jeremystretch commented Jun 29, 2023

Thanks @DanSheps!

@jeremystretch jeremystretch merged commit f69d99e into develop Jun 29, 2023
@jeremystretch jeremystretch deleted the 12760-Vary-HTMX-Requests branch June 29, 2023 19:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jeremystretch jeremystretch Awaiting requested review from jeremystretch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sporadically broken HTML formatting since at least 3.5.0

3 participants

@DanSheps @jeremystretch