Skip to content

Conversation

@abhi1693
Copy link
Member

Fixes: #12597

@abhi1693 abhi1693 requested a review from jeremystretch May 25, 2023 19:48
@jeremystretch
Copy link
Member

jeremystretch commented May 26, 2023

I think it would be cleaner to tackle the conditional logic under get_custom_fields_by_group() since we're already handling the omission of fully hidden fields there. (Plus it avoids having to deal with the duplicated template code.)

@abhi1693
Copy link
Member Author

@jeremystretch I have updated the code as per your suggestion

@jeremystretch jeremystretch merged commit d7ca453 into develop May 30, 2023
@abhi1693 abhi1693 deleted the feat/12597-cf-visibility branch May 30, 2023 13:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom Field UI visibility option "Hidden if unset"

4 participants