Skip to content

Closes #9068: validate addresses assigned to interfaces #12618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 22, 2023
Merged

Closes #9068: validate addresses assigned to interfaces #12618

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4ea3fad
Begin logic
decoupca May 15, 2023
1596821
Closes #9068: Disallow assigning bcast/networks to interfaces
decoupca May 15, 2023
478b27a
Allow net IDs in /31, /32, /127, /128
decoupca May 15, 2023
7389147
linting error
decoupca May 15, 2023
0b0977d
Implement requested changes
decoupca May 16, 2023
0338f56
Condensed the "if" logic a bit
jeremystretch May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions netbox/ipam/forms/model_forms.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,18 @@ def clean(self):
'primary_for_parent', "Only IP addresses assigned to an interface can be designated as primary IPs."
)

# Do not allow assigning a network ID or broadcast address to an interface.
if interface and (address := self.cleaned_data.get('address')):
if address.ip == address.network:
msg = f"{address} is a network ID, which may not be assigned to an interface."
if address.version == 4 and address.prefixlen not in (31, 32):
raise ValidationError(msg)
if address.version == 6 and address.prefixlen not in (127, 128):
raise ValidationError(msg)
if address.ip == address.broadcast:
msg = f"{address} is a broadcast address, which may not be assigned to an interface."
raise ValidationError(msg)

def save(self, *args, **kwargs):
ipaddress = super().save(*args, **kwargs)

Expand Down