Adds maintenance exempt paths #12592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
reviewed
May 15, 2023
Collaborator
arthanson
left a comment
arthanson
left a comment
There was a problem hiding this comment.
I think this needs documentation for how to enable maintenance mode in read-only configuration?
Member
|
With this fix in place, it's possible to toggle maintenance mode on/off via the dynamic configuration as well as via |
Member
Author
|
@jeremystretch Do you think it's a good idea to remove the login and logout from the exemption? If the application is in maintenance and someone tried to logout, they will probably see an issue with session handling and the page might crash or display server error view. |
jsenecal
pushed a commit
to jsenecal/netbox
that referenced
this pull request
May 18, 2023
* adds maintenance exempt paths netbox-community#11233 * adds maintenance exempt paths netbox-community#11233 * Rename method & remove login/logout from exempt paths --------- Co-authored-by: jeremystretch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11233